Port to ppxlib registration and attributes #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NathanReb Since this is along the lines of ocaml-ppx/ppx_deriving#263 and that a release of ppx_deriving_yojson might be due (ocaml/opam-repository#25675 (comment)), then this would also make sense to synchronize similar changes. |
|
Yeah, I was looking into this just yesterday and was pleasantly suprised to see you had already worked on a ppxlib port. I will review this ASAP! |
NathanReb
reviewed
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to ocaml-ppx/ppx_deriving#263. This doesn't necessarily depend on that PR, but some of the same criticism applies.
In particular the point about[%derive.to_yojson: ...]and[%derive.of_yojson: ...]being unsupported through ppxlib directly. According to sherlocode, only ocurrent uses one of these.Nevermind, the support can be preserved using a custom extension.