Update a function pattern to avoid warning 68 (when enabled). #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
panglesd
approved these changes
Jul 28, 2022
pitag-ha
added a commit
to pitag-ha/opam-repository
that referenced
this pull request
Oct 5, 2022
CHANGES: - Make `esequence` right-associative. (ocaml-ppx/ppxlib#366, @ceastlund) - Deprecate unused attributes in `Deriving.Generator` (ocaml-ppx/ppxlib#368, @sim642) - Remove a pattern match on mutable state in a function argument. (ocaml-ppx/ppxlib#362, @ceastlund) - Add code-path manipulation attributes. (ocaml-ppx/ppxlib#352, @ceastlund) - Update context-free rules to collect expansion errors generated by ppxlib and propagate them to top level without failing. (ocaml-ppx/ppxlib#358 and ocaml-ppx/ppxlib#361, @ceastlund)
pitag-ha
added a commit
to pitag-ha/opam-repository
that referenced
this pull request
Oct 6, 2022
CHANGES: - Make `esequence` right-associative. (ocaml-ppx/ppxlib#366, @ceastlund) - Deprecate unused attributes in `Deriving.Generator` (ocaml-ppx/ppxlib#368, @sim642) - Remove a pattern match on mutable state in a function argument. (ocaml-ppx/ppxlib#362, @ceastlund) - Add code-path manipulation attributes. (ocaml-ppx/ppxlib#352, @ceastlund) - Update context-free rules to collect expansion errors generated by ppxlib and propagate them to top level without failing. (ocaml-ppx/ppxlib#358 and ocaml-ppx/ppxlib#361, @ceastlund)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids pattern matching on mutable state in a function parameter.