Fix packaging #548
Open
Fix packaging #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
requested review from
ceastlund,
panglesd,
patricoferris and
pitag-ha
as code owners
NathanReb
added
the
no changelog
|
It seems we can't currently allocate cinaps stanzas to specific packages so I ended up also adding a test deps on cinaps in ppxlib-tools for now. I reported this upstream: ocaml/dune#11232. If there's a better, easier fix, I'll of course patch this before the release! |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
fix-packaging
branch
from
a8ee1f3 to
b9b38f8
Compare
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
fix-packaging
branch
from
c1b380c to
7e2e660
Compare
|
Not sure I understand what's wrong with the bench build, are you any more familiar with it than I am @patricoferris ? |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
|
Ok the question rather was how did it even work before but I fixed it. It needed an explicitly declared dependency on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some errors while testing out the repo before attempting the release, this should fix those:
ppxlibso they aren't run when running something likedune build -p ppxlib-toolsoropam install -t ppxlib-tools. This prevent some test dependencies to leak fromppxlibtoppxlib-tools.1, I actually ended up having to bump it to 3.8. This enabled some warnings that I guess where not part of the default build profile before and I ended up fixing those as well.