Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(static-binaries): Fix building of static binaries on CI #497

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

yurug
Copy link
Collaborator

@yurug yurug commented Sep 15, 2022

  • Kind: bugfix

Description

We use another docker image to build the static binairies under GNU/Linux.

@yurug yurug force-pushed the fix-static-binaries-build branch 2 times, most recently from 473202d to fb2ffdf Compare September 15, 2022 07:56
Copy link
Member

@erikmd erikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @yurug for this small but decisive patch!

@erikmd erikmd merged commit bcb0ff7 into master Sep 15, 2022
@erikmd erikmd deleted the fix-static-binaries-build branch September 15, 2022 20:53
@erikmd erikmd self-assigned this Nov 27, 2022
erikmd added a commit to AltGr/learn-ocaml that referenced this pull request Dec 29, 2022
… pr/481 (to-be-rebased)

* 'master' of https://github.com/ocaml-sf/learn-ocaml:
  fix(learnocaml_report.css): Display multiple spaces in code excerpts (ocaml-sf#503)
  ci(pin-artifacts.yml): Add build artifacts links within upstream commits status (ocaml-sf#501)
  deps(opam): Bump ssl (0.5.10 -> 0.5.12) (ocaml-sf#499)
  build(static-binaries): Fix building of static binaries on CI (ocaml-sf#497)
@erikmd erikmd added this to the learn-ocaml 0.14.1 milestone Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Static binaries failed to build on Linux under the environment of Github CI
2 participants