Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast path for Z.divisible on small arguments #147

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fast path for Z.divisible on small arguments #147

merged 1 commit into from
Nov 20, 2023

Conversation

xavierleroy
Copy link
Contributor

It was observed in #140 that Z.divisible x y can be slower than Z.rem x y = Z.zero, esp. for small arguments. This PR adds a fast path to Z.divisible for small arguments x and y.

@antoinemine
Copy link
Collaborator

Seems good to me, thanks!

pascal-cuoq
pascal-cuoq reviewed Nov 15, 2023
View reviewed changes
z.ml Show resolved Hide resolved
@xavierleroy xavierleroy merged commit 524a489 into ocaml:master Nov 20, 2023
8 checks passed
@xavierleroy xavierleroy deleted the faster-divisible branch November 20, 2023 13:29
@xavierleroy xavierleroy mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-cuoq pascal-cuoq pascal-cuoq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavierleroy @antoinemine @pascal-cuoq