Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Q.of_string #72

Merged
merged 8 commits into from
Sep 21, 2020
Merged

Fix Q.of_string #72

merged 8 commits into from
Sep 21, 2020

Commits on Sep 15, 2020

  1. Fix Q.of_string 

    - exponent are parsed in decimal base
- the base prefix is case insensitive (allow 0x and 0X)
- fix parsing of hexadecimal with radix
- reduce the number of string allocation
    @hhugo
    hhugo committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    35c7e34 View commit details
    Browse the repository at this point in the history

  2. small refactor

    @hhugo
    hhugo committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e24df10 View commit details
    Browse the repository at this point in the history

  3. make the code more robust to future changes

    @hhugo
    hhugo committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    862b0ff View commit details
    Browse the repository at this point in the history

  4. add and fix tests

    @hhugo
    hhugo committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    89fd0e5 View commit details
    Browse the repository at this point in the history

  5. refactor

    @hhugo
    hhugo committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    d36791e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. restore compat with ocaml 3.12

    @hhugo
    hhugo committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    3f9470c View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Fix typo 

    Co-authored-by: Xavier Leroy <xavierleroy@users.noreply.github.com>
    @hhugo @xavierleroy
    hhugo and xavierleroy authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f08a4ec View commit details
    Browse the repository at this point in the history

  2. move find_in_string out

    @hhugo
    hhugo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    c3c4763 View commit details
    Browse the repository at this point in the history