Fix parallel build. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running "make -j", the build fails because there are no rules to build .cmti files. (They are byproducts of .cmi files.) It also fails because it invokes ocamlmklib twice for generating both zarith.cmxa and zarith.a, thus corrupting files. Thus, instead of depending on the whole content of TOINSTALL, the "all" rule now depends only on a subset large enough to trigger all the rules. The downside is that one can no longer type "make zarith.a". Instead, one has to type "make zarith.cmxa" (or just "make").
xavierleroy
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
make -j, the build fails because there are no rules to build.cmtifiles. (They are byproducts of.cmifiles.)It also fails because it invokes
ocamlmklibtwice for generating bothzarith.cmxaandzarith.a, thus corrupting files.Thus, instead of depending on the whole content of
TOINSTALL, theallrule now depends only on a subset large enough to trigger all the rules.The downside is that one can no longer type
make zarith.a. Instead, one has to typemake zarith.cmxa(or justmake).