fix: dir_contents from select library dep in test stanza

Signed-off-by: Ali Caglayan <alizter@gmail.com>
ocaml · Dec 5, 2023 · 093170f · 093170f
1 parent 9059182
commit 093170f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/doc/changes/9387.md b/doc/changes/9387.md
@@ -0,0 +1,2 @@
+- Fixed a bug where the `(select)` field of the `(libraries)` field of the
+  `(test)` stanza wasn't working properly. (#9387, fixes #9365, Alizter)
diff --git a/src/dune_rules/dir_contents.ml b/src/dune_rules/dir_contents.ml
@@ -206,7 +206,9 @@ end = struct
             >>| Path.Set.to_list_map ~f:Path.basename
           | Generate_sites_module_stanza.T def ->
             Generate_sites_module_rules.setup_rules sctx ~dir def >>| List.singleton
-          | Library.T { buildable; _ } | Executables.T { buildable; _ } ->
+          | Library.T { buildable; _ }
+          | Executables.T { buildable; _ }
+          | Tests.T { exes = { buildable; _ }; _ } ->
             let select_deps_files = select_deps_files buildable.libraries in
             let ctypes_files =
               (* Also manually add files generated by ctypes rules. *)

diff --git a/test/blackbox-tests/test-cases/select-in-test.t b/test/blackbox-tests/test-cases/select-in-test.t
@@ -25,8 +25,4 @@ The select field does not pick up the module sources for the test stanza
 correctly. This is a bug.
 
   $ dune runtest  
-  File "dune", line 3, characters 10-14:
-  3 |  (modules test)
-                ^^^^
-  Error: Module Test doesn't exist.
-  [1]
+  Test: Unix was found!
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- Fixed a bug where the `(select)` field of the `(libraries)` field of the
		`(test)` stanza wasn't working properly. (#9387, fixes #9365, Alizter)