Fix noisy empty strings

Signed-off-by: Louis Gesbert <louis.gesbert@ocamlpro.com> Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
ocaml · Oct 11, 2019 · 3a7a442 · 3a7a442
1 parent 5f65259
commit 3a7a442
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -152,6 +152,8 @@
 
 - Do not setup rules for disabled libraries (#2491, fixes #2272, @bobot)
 
+- Configurator: filter out empty flags from `pkg-config` (#2716, @AltGr)
+
 1.11.4 (09/10/2019)
 -------------------
 

diff --git a/otherlibs/configurator/src/v1.ml b/otherlibs/configurator/src/v1.ml
@@ -631,7 +631,7 @@ module Pkg_config = struct
             (Process.run_capture_exn c ~dir ?env t.pkg_config [ what; package ])
         with
         | "" -> []
-        | s -> String.split s ~on:' '
+        | s -> String.extract_blank_separated_words s
       in
       Ok { libs = run "--libs"; cflags = run "--cflags" }
     else
-Original file line number
+Diff line change
@@ Expand Up / @@ -152,6 +152,8 @@ @@
     - Do not setup rules for disabled libraries (#2491, fixes #2272, @bobot)
+    - Configurator: filter out empty flags from `pkg-config` (#2716, @AltGr)
 .11.4 (09/10/2019)
     -------------------
@@ Expand Down @@