Skip to content

Commit

Permalink
refactor(pkg): leave CR for untimely update
Browse files Browse the repository at this point in the history
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: ef51b04c-90c3-4713-b373-a2d8de169f2a -->
  • Loading branch information
rgrinberg committed Jan 5, 2024
1 parent 2dd4b30 commit 3fa4b53
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/dune_pkg/opam_repo.ml
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ let of_git_repo ~update (source : Source.t) =
| _ -> None
in
let* remote = Rev_store.add_repo repo ~source:source.url ~branch in
(* CR-rgrinberg: We need to update before deciding whether a ref is a tag
or a branch, yet we already have [source], so we've determined this
[source] with out of date info? *)
match update with
| true -> Rev_store.Remote.update remote
| false -> Fiber.return @@ Rev_store.Remote.don't_update remote
Expand Down

0 comments on commit 3fa4b53

Please sign in to comment.