fix: disable background threads where we use fork

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
ocaml · Jul 4, 2023 · 57f9a7c · 57f9a7c
1 parent dccec21
commit 57f9a7c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,9 @@
+Unreleased
+----------
+
+- Disable background operations on MacOS and other Unixes where we rely on
+  fork. (#8100, fixes #8083, @rgrinberg)
+
 3.9.0 (2023-06-28)
 ------------------
 

diff --git a/src/dune_config/config.ml b/src/dune_config/config.ml
@@ -97,6 +97,11 @@ let copy_file =
   register t;
   t
 
+let background_default =
+  match Platform.OS.value with
+  | Linux | Windows -> `Enabled
+  | _ -> `Disabled
+
 let background_actions =
   let t =
     { name = "background_actions"
@@ -111,7 +116,7 @@ let background_digests =
   let t =
     { name = "background_digests"
     ; of_string = Toggle.of_string
-    ; value = `Enabled
+    ; value = background_default
     }
   in
   register t;
@@ -121,7 +126,7 @@ let background_sandboxes =
   let t =
     { name = "background_sandboxes"
     ; of_string = Toggle.of_string
-    ; value = `Enabled
+    ; value = background_default
     }
   in
   register t;