Add reproduction case for #3252

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

test/blackbox-tests/dune.inc

@@ -38,6 +38,14 @@
    test-cases/bad-alias-error
    (progn (run dune-cram run run.t) (diff? run.t run.t.corrected)))))
 
+(rule
+ (alias bin-eager-deps)
+ (deps (package dune) (source_tree test-cases/bin-eager-deps))
+ (action
+  (chdir
+   test-cases/bin-eager-deps
+   (progn (run dune-cram run run.t) (diff? run.t run.t.corrected)))))
+
 (rule
  (alias block-strings)
  (deps (package dune) (source_tree test-cases/block-strings))
@@ -2392,6 +2400,7 @@
   (alias all-alias)
   (alias all-promotions)
   (alias bad-alias-error)
+  (alias bin-eager-deps)
   (alias block-strings)
   (alias byte-code-only)
   (alias byte_complete)
@@ -2677,6 +2686,7 @@
   (alias all-alias)
   (alias all-promotions)
   (alias bad-alias-error)
+  (alias bin-eager-deps)
   (alias block-strings)
   (alias byte-code-only)
   (alias byte_complete)

test/blackbox-tests/test-cases/bin-eager-deps/run.t

@@ -0,0 +1,24 @@
+Reproduces issue #3252
+
+https://github.com/ocaml/dune/issues/3252
+
+If a rule requires an expansion that introduces a failure, we should fail only
+when the rule needs to be used to build a target.
+
+  $ cat >dune-project <<EOF
+  > (lang dune 2.0)
+  > (package (name randompackage))
+  > EOF
+  $ cat >dune <<EOF
+  > (rule
+  >  (targets testfile)
+  >  (deps %{bin:doesnotexistbinary})
+  >  (action (echo "test")))
+  > EOF
+  $ dune build @install --display short
+  File "dune", line 3, characters 9-32:
+  3 |  (deps %{bin:doesnotexistbinary})
+               ^^^^^^^^^^^^^^^^^^^^^^^
+  Error: Program doesnotexistbinary not found in the tree or in PATH
+   (context: default)
+  [1]