Do not allow actions to create dirs outside of build dir

Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
ocaml · May 15, 2019 · 698d7ea · 698d7ea
1 parent 12a7489
commit 698d7ea
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/action_exec.ml b/src/action_exec.ml
@@ -108,7 +108,14 @@ let rec exec t ~ectx ~dir ~env ~stdout_to ~stderr_to =
     Path.rm_rf path;
     Fiber.return ()
   | Mkdir path ->
-    Path.mkdir_p path;
+    begin
+      if Path.is_in_build_dir path then
+        Path.mkdir_p path
+      else if Path.exists path then
+        ()
+      else
+        die "action attempted to create %a outside the build dir" Path.pp path
+    end;
     Fiber.return ()
   | Digest_files paths ->
     let s =