Skip to content

Commit

Permalink
refactor the code
Browse files Browse the repository at this point in the history
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
  • Loading branch information
moyodiallo committed Jul 7, 2023
1 parent 64e8d71 commit 9055d5d
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions bin/describe/describe_external_lib_deps.ml
Original file line number Diff line number Diff line change
Expand Up @@ -43,20 +43,21 @@ module Item = struct
; extensions : string list
}

let to_dyn {kind; dir; external_deps; internal_deps; names; package; extensions} =
let to_dyn
{ kind; dir; external_deps; internal_deps; names; package; extensions } =
let open Dyn in
let record =
record
[ ("names", (list string) t.names)
; ("extensions", (list string) t.extensions)
[ ("names", (list string) names)
; ("extensions", (list string) extensions)
; ( "package"
, option Package.Name.to_dyn (Option.map ~f:Package.name t.package) )
; ("source_dir", String (Path.Source.to_string t.dir))
; ("external_deps", list lib_dep_to_dyn t.external_deps)
; ("internal_deps", list lib_dep_to_dyn t.internal_deps)
, option Package.Name.to_dyn (Option.map ~f:Package.name package) )
; ("source_dir", String (Path.Source.to_string dir))
; ("external_deps", list lib_dep_to_dyn external_deps)
; ("internal_deps", list lib_dep_to_dyn internal_deps)
]
in
Variant (Kind.to_string t.kind, [ record ])
Variant (Kind.to_string kind, [ record ])
end

type dep =
Expand Down Expand Up @@ -172,7 +173,7 @@ let external_resolved_libs setup super_context =
let db = Dune_rules.Scope.libs scope in
libs db context setup
>>| List.filter ~f:(fun (x : Item.t) ->
not (List.is_empty x.external_deps && List.is_empty x.internal_deps)
not (List.is_empty x.external_deps && List.is_empty x.internal_deps))

let to_dyn context_name external_resolved_libs =
let open Dyn in
Expand Down

0 comments on commit 9055d5d

Please sign in to comment.