Merge pull request #3958 from rgrinberg/remove-running-count

[scheduler] Remove running count
ocaml · Nov 19, 2020 · ac4aa91 · ac4aa91
2 parents d39fed9 + 179d2d1
commit ac4aa91
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/dune_engine/scheduler.ml b/src/dune_engine/scheduler.ml
@@ -421,14 +421,11 @@ end = struct
        in [table]. *)
     let table = Table.create (module Pid) 128
 
-    let running_count = ref 0
-
     let add job =
       match Table.find table job.pid with
       | None ->
         Table.set table job.pid (Running job);
-        incr running_count;
-        if !running_count = 1 then Condition.signal something_is_running_cv
+        if Table.length table = 1 then Condition.signal something_is_running_cv
       | Some (Zombie status) ->
         Table.remove table job.pid;
         Event.send_job_completed job status
@@ -438,7 +435,6 @@ end = struct
       match Table.find table pid with
       | None -> Table.set table pid (Zombie status)
       | Some (Running job) ->
-        decr running_count;
         Table.remove table pid;
         Event.send_job_completed job status
       | Some (Zombie _) -> assert false
@@ -449,7 +445,7 @@ end = struct
           | Running job -> f job
           | Zombie _ -> ())
 
-    let running_count () = !running_count
+    let running_count () = Table.length table
   end
 
   let register_job job =