Skip to content

Commit

Permalink
fix: do not re-run jbuild syntax dune files on every run (#7894)
Browse files Browse the repository at this point in the history
While this is more correct, it ends up being too slow in practice
especially since we don't have cut-off on the results

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
  • Loading branch information
rgrinberg authored Jun 6, 2023
1 parent b7413e5 commit e1f3e19
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Unreleased
----------

- Do not re-run OCaml syntax files on every iteration of the watch mode. This
is too memory consuming. (#7894, fix #6900, @rgrinberg)

- Fix a crash when using a version of Coq < 8.13 due to the native compiler
config variable being missing. We now explicitly default to `(mode vo)` for
these older versions of Coq. (#7847, fixes #7846, @Alizter)
Expand Down
1 change: 0 additions & 1 deletion src/dune_rules/dune_load.ml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ module Script = struct
in
let ocaml = Action.Prog.ok_exn context.ocaml.ocaml in
let* () =
let* (_ : Memo.Run.t) = Memo.current_run () in
Memo.of_reproducible_fiber
(Process.run Strict ~display:Quiet ~dir:(Path.source dir)
~env:context.env ocaml args)
Expand Down

0 comments on commit e1f3e19

Please sign in to comment.