Dune cache does not restore empty directories.

[mefyl]

Issue

Dune cache does not restore empty directories. On top of not being very nice, this has really bad consequences with caching because dune's rule digest algorithm does take empty directories in account, so restoring a rule from cache will invalidate all dependent rules as the sources hash will have changed.

This is especially painful with the dune pkg feature, as the Ocaml 5.2.0 tarball has an empty flexdll directory at the root, so pulling it from the cache will rebuild absolutely everything.

I suppose the correct behavior is to properly restore empty directories from cache. If not, they probably shouldn't count towards rule digests.

Reproduction

• PR with a reproducing test: Add failing test pulling empty directory from cache. #11116

[ejgallego]

Could this be related to #10931 ?

[ElectreAAS]

Could this be related to #10931 ?

I am suspecting as such yes...
After working on #11203 I no longer think this is the case, but I might be wrong 😅