Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix directory targets with empty subdirs #11226

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ElectreAAS
Copy link
Collaborator

@ElectreAAS ElectreAAS commented Dec 18, 2024

This PR is related to... a lot of things actually.

For some context, let's take this test file from #11116 & #11117:
Why isn't the empty directory output/child restored from cache like output/file?

I'm not really sure, and the original author of this piece of code (rleshchinskiy) doesn't seem very active in this project at this time.
What I am sure of is that breaking the logic of collect is easy to do accidentally, but that at least fixes one problem.

Debugging this is tricky, as a lot of tests fail with a cryptic

Error: Is a directory
-> required by _build/default/a
[1]

I'll note however that the problems likely originates in either #9407, #9470, or #9535.

@ElectreAAS ElectreAAS changed the title WIP: directory targets with empty subdirs WIP: fix directory targets with empty subdirs Dec 18, 2024
@ElectreAAS
Copy link
Collaborator Author

cc-ing the entire planet for good measure, but don't feel obligated to participate (it's the holiday season after all 😃)

@maiste @rgrinberg @rleshchinskiy @snowleopard @moyodiallo @mefyl @ejgallego

Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Copy link
Collaborator Author

Update before the week-end (I'll refine this on monday):
Changed the internal representation to be hierarchical - it feels like the right move to detect broken logic, but I'm not 100% convinced.
Left some fun comments for reviewers, and a fair amount of printing stuff

Note that the changed test 'empty-dir' actually passes (besides the printing), but the added one 'subdirs-only' fails like those in the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant