WIP: fix directory targets with empty subdirs #11226
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to... a lot of things actually.
For some context, let's take this test file from #11116 & #11117:
Why isn't the empty directory
output/child
restored from cache likeoutput/file
?I'm not really sure, and the original author of this piece of code (rleshchinskiy) doesn't seem very active in this project at this time.
What I am sure of is that breaking the logic of
collect
is easy to do accidentally, but that at least fixes one problem.Debugging this is tricky, as a lot of tests fail with a cryptic
I'll note however that the problems likely originates in either #9407, #9470, or #9535.