Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing options to test stanzas #1195

Closed
samoht opened this issue Aug 29, 2018 · 4 comments
Closed

passing options to test stanzas #1195

samoht opened this issue Aug 29, 2018 · 4 comments
Assignees
@emillon

Comments

@samoht
Copy link
Member

samoht commented Aug 29, 2018 •
edited
Loading

The new test stanza is great but it doesn't seem to be possible to pass options to the executable. Would be great to be able to do something like:

(test
 (modules   test)
 (libraries test_lib))
 (args      (-q --color=always)))

or something similar.
@emillon emillon self-assigned this Aug 30, 2018
@emillon
Copy link
Collaborator

emillon commented Aug 30, 2018

Yes, at the moment it's hardcoded:

dune/src/gen_rules.ml

Line 193 in 265adc8

(String_with_vars.make_text loc ("./" ^ s ^ ".exe"), []) in

Providing (args) seems to be a good interface for this 👍

@ghost
Copy link

ghost commented Aug 31, 2018

What about (action (run %{prog} -q --color=always))? That should handle even more cases.

@rgrinberg
Copy link
Member

Action seems preferable as well. I'm wondering why %{prog} over %{test} for example.

@ghost
Copy link

ghost commented Aug 31, 2018

No reason, %{test} seems good

emillon added a commit that referenced this issue Sep 10, 2018
@emillon
Customize how (test) is run using (action)
f10eaea 
Closes #1195

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this issue Sep 10, 2018
@emillon
Customize how (test) is run using (action)
ce267f5 
Closes #1195

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this issue Sep 10, 2018
@emillon
Customize how (test) is run using (action)
729c1e1 
Closes #1195

Signed-off-by: Etienne Millon <me@emillon.org>
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Sep 14, 2018
@rgrinberg
[new release] dune (1.2.0)
64d5a2a 
CHANGES:

- Ignore stderr output when trying to find out the number of jobs
  available (ocaml/dune#1118, fix ocaml/dune#1116, @diml)

- Fix error message when the source directory of `copy_files` does not exist.
  (ocaml/dune#1120, fix ocaml/dune#1099, @emillon)

- Highlight error locations in error messages (ocaml/dune#1121, @emillon)

- Display actual stanza when package is ambiguous (ocaml/dune#1126, fix ocaml/dune#1123, @emillon)

- Add `dune unstable-fmt` to format `dune` files. The interface and syntax are
  still subject to change, so use with caution. (ocaml/dune#1130, fix ocaml/dune#940, @emillon)

- Improve error message for `dune utop` without a library name (ocaml/dune#1154, fix
  ocaml/dune#1149, @emillon)

- Fix parsing `ocamllex` stanza in jbuild files (ocaml/dune#1150, @rgrinberg)

- Highlight multi-line errors (ocaml/dune#1131, @anuragsoni)

- Do no try to generate shared libraries when this is not supported by
  the OS (ocaml/dune#1165, fix ocaml/dune#1051, @diml)

- Fix `Flags.write_{sexp,lines}` in configurator by avoiding the use of
  `Stdune.Path` (ocaml/dune#1175, fix ocaml/dune#1161, @rgrinberg)

- Add support for `findlib.dynload`: when linking an executable using
  `findlib.dynload`, automatically record linked in libraries and
  findlib predicates (ocaml/dune#1172, @bobot)

- Add support for promoting a selected list of files (ocaml/dune#1192, @diml)

- Add an emacs mode providing helpers to promote correction files
  (ocaml/dune#1192, @diml)

- Improve message suggesting to remove parentheses (ocaml/dune#1196, fix ocaml/dune#1173, @emillon)

- Add `(wrapped (transition "..message.."))` as an option that will generate
  wrapped modules but keep unwrapped modules with a deprecation message to
  preserve compatibility. (ocaml/dune#1188, fix ocaml/dune#985, @rgrinberg)

- Fix the flags passed to the ppx rewriter when using `staged_pps` (ocaml/dune#1218, @diml)

- Add `(env var)` to add a dependency to an environment variable.
  (ocaml/dune#1186, @emillon)

- Add a simple version of a polling mode: `dune build -w` keeps
  running and restarts the build when something change on the
  filesystem (ocaml/dune#1140, @kodek16)

- Cleanup the way we detect the library search path. We no longer call
  `opam config var lib` in the default build context (ocaml/dune#1226, @diml)

- Make test stanzas honor the -p flag. (ocaml/dune#1236, fix ocaml/dune#1231, @emillon)

- Test stanzas take an optional (action) field to customize how they run (ocaml/dune#1248,
  ocaml/dune#1195, @emillon)

- Add support for private modules via the `private_modules` field (ocaml/dune#1241, fix
  ocaml/dune#427, @rgrinberg)

- Add support for passing arguments to the OCaml compiler via a
  response file when the list of arguments is too long (ocaml/dune#1256, @diml)

- Do not print diffs by default when running inside dune (ocaml/dune#1260, @diml)

- Interpret `$ dune build dir` as building the default alias in `dir`. (ocaml/dune#1259,
  @rgrinberg)

- Make the `dynlink` library available without findlib installed (ocaml/dune#1270, fix
  ocaml/dune#1264, @rgrinberg)
@rgrinberg rgrinberg mentioned this issue Sep 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emillon emillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samoht @rgrinberg @emillon