Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pkg-config tests to configurator #1838

Closed
rgrinberg opened this issue Feb 13, 2019 · 4 comments
Closed

Add pkg-config tests to configurator #1838

rgrinberg opened this issue Feb 13, 2019 · 4 comments
Assignees
@rgrinberg

Comments

@rgrinberg
Copy link
Member

They've been the cause of serious regressions such as #1833 in the past.
@rgrinberg rgrinberg mentioned this issue Feb 13, 2019
Closed
@Chris00
Copy link
Member

Chris00 commented Feb 13, 2019

To be clear: you are fine to depend on conf-pkg-config for tests, right?

@rgrinberg
Copy link
Member Author

Yeah, I think we have plenty of tests that require external dependencies. But for the quoting issue, I'm thinking that it would be enough to have a mock pkg-config that would simply prints its arguments and give a fake return code. It should be enough to make sure we are running it as we expect.

@rgrinberg rgrinberg self-assigned this Feb 14, 2019
@rgrinberg
Copy link
Member Author

@Chris00 I'm taking care of this

@rgrinberg
Copy link
Member Author

There's a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrinberg rgrinberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrinberg @Chris00