Fix double quoting of pkg-config when package contains a space #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: Pkg_config.query p ~package:"gtk+-3.0 >= 3.10" Fixes ocaml#1833 Signed-off-by: Christophe Troestler <Christophe.Troestler@umons.ac.be>
rgrinberg
approved these changes
Feb 13, 2019
Signed-off-by: Christophe Troestler <Christophe.Troestler@umons.ac.be>
|
@rgrinberg Improved doc. |
|
Thanks! Would it be possible to add a test? This kind of stuff seems very tricky along different OS, so I'd be great to have CI check it at least on Linux / OSX |
|
I merged this and created an issue with regards to testing configurator's pkg-config support: #1838 |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 13, 2019
CHANGES: - Fix the watch mode (ocaml/dune#1837, ocaml/dune#1839, fix ocaml/dune#1836, @diml) - Configurator: Fix misquoting when running pkg-config (ocaml/dune#1835, fix ocaml/dune#1833, @Chris00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: Pkg_config.query p ~package:"gtk+-3.0 >= 3.10"
Fixes #1833
I have tested the fix.