Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression introduced by #2041 #2123

Closed
rgrinberg opened this issue May 5, 2019 · 0 comments · Fixed by ocaml/opam-repository#14098
Closed

Regression introduced by #2041 #2123

rgrinberg opened this issue May 5, 2019 · 0 comments · Fixed by ocaml/opam-repository#14098

Comments

@rgrinberg
Copy link
Member

#2041 introduces a regression as discovered by @hannes here
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue May 5, 2019
@rgrinberg
Add test case to reproduce ocaml#2123
a810bdf 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue May 5, 2019
@rgrinberg
Fix ocaml#2123 by reverting ocaml#2041
b251e64 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue May 5, 2019
@rgrinberg
Fix ocaml#2123 by reverting ocaml#2041
9cc3d96 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit that referenced this issue May 6, 2019
@rgrinberg
Fix #2123 (#2124)
9c520aa 
Fix #2123
rgrinberg added a commit that referenced this issue May 6, 2019
@rgrinberg
Add test case to reproduce #2123
786797d 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit that referenced this issue May 6, 2019
@rgrinberg
Fix #2123 by reverting #2041
ebf6192 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit that referenced this issue May 6, 2019
@rgrinberg
Fix #2123 by reverting #2041
edf8c7a 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue May 6, 2019
@rgrinberg
[new release] dune (1.9.3)
7bcbf1e 
CHANGES:

- Fix `.install` files not being generated (ocaml/dune#2124, fixes ocaml/dune#2123, @rgrinberg)
@rgrinberg rgrinberg mentioned this issue May 6, 2019
Merged
mlasson pushed a commit to mlasson/dune that referenced this issue Jul 19, 2019
@rgrinberg @mlasson
Add test case to reproduce ocaml#2123
224bf74 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
mlasson pushed a commit to mlasson/dune that referenced this issue Jul 19, 2019
@rgrinberg @mlasson
Fix ocaml#2123 by reverting ocaml#2041
c6f64e6 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
@gridbugs gridbugs mentioned this issue Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new release] dune (1.9.3) rgrinberg/opam-repository
1 participant
@rgrinberg