Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 1.10. Building other targets removes installed files #2228

Closed
rgrinberg opened this issue Jun 2, 2019 · 0 comments
Closed

Regression in 1.10. Building other targets removes installed files #2228

rgrinberg opened this issue Jun 2, 2019 · 0 comments

Comments

@rgrinberg
Copy link
Member

rgrinberg commented Jun 2, 2019 •
edited
Loading

Details are here: ocaml/opam-repository#14215 (comment) and I'm preparing a reproduction case.

cc @kit-ty-kate
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Jun 2, 2019
@rgrinberg
Reproduction case for ocaml#2228
c9b5638 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Jun 2, 2019
@rgrinberg
Reproduction case for ocaml#2228
391488e 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
aalekseyev pushed a commit that referenced this issue Jun 3, 2019
@rgrinberg @aalekseyev
Reproduction case for #2228 (#2229)
cdaf241 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
aalekseyev added a commit to aalekseyev/dune that referenced this issue Jun 3, 2019
@aalekseyev
fix ocaml#2228
a632d8c 
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
@aalekseyev aalekseyev mentioned this issue Jun 3, 2019
Merged
mlasson pushed a commit to mlasson/dune that referenced this issue Jul 19, 2019
@rgrinberg @mlasson
Reproduction case for ocaml#2228 (ocaml#2229)
e8a7d06 
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
mlasson pushed a commit to mlasson/dune that referenced this issue Jul 19, 2019
@aalekseyev @mlasson
fix ocaml#2228 (ocaml#2239)
530c261 
Correctly keep track of install subdirectories to keep.

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgrinberg