You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I used the internal name of a library for default_implementation rather than the public_name. I initially didn't notice because the library was vendored, but did unexpectedly notice when I pinned the package in opam and built that way, since the dune-package file then contains a name which isn't in scope.
If the library referenced has a public_name, shouldn't Dune either insist on its being used in the default_implementation field or should it silently convert it to the public_name when it writes a dune-package file?
The text was updated successfully, but these errors were encountered:
CHANGES:
- Remove the optimisation of passing `-nodynlink` for executalbes when
not necessary. It seems to be breaking things (see ocaml/dune#2527, @diml)
- Fix invalid library names in `dune-package` files. Only public names should
exist in such files. (ocaml/dune#2558, fixocaml/dune#2425, @rgrinberg)
I used the internal name of a library for
default_implementation
rather than thepublic_name
. I initially didn't notice because the library was vendored, but did unexpectedly notice when I pinned the package inopam
and built that way, since thedune-package
file then contains a name which isn't in scope.If the library referenced has a
public_name
, shouldn't Dune either insist on its being used in thedefault_implementation
field or should it silently convert it to thepublic_name
when it writes adune-package
file?The text was updated successfully, but these errors were encountered: