Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dune sites doesn't work when installed by opam #4212

Closed
bobot opened this issue Feb 10, 2021 · 4 comments
Closed

Dune sites doesn't work when installed by opam #4212

bobot opened this issue Feb 10, 2021 · 4 comments
Assignees
@bobot
Milestone
2.9

Comments

@bobot
Copy link
Collaborator

bobot commented Feb 10, 2021

Because opam doesn't go through dune install, but copy directly from the _build directory
@bobot bobot added this to the 2.9 milestone Feb 10, 2021
@bobot bobot self-assigned this Feb 10, 2021
@bobot bobot mentioned this issue Mar 8, 2021
Closed
@Kakadu Kakadu mentioned this issue Mar 19, 2021
Merged
@bobot bobot mentioned this issue Mar 24, 2021
Closed
bobot added a commit to bobot/jbuilder that referenced this issue May 21, 2021
@bobot
[Sites] Fix installation through opam
3ad9879 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212
@bobot bobot mentioned this issue May 21, 2021
Merged
bobot added a commit to bobot/jbuilder that referenced this issue May 25, 2021
@bobot
[Sites] Fix installation through opam
ead1fe8 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212
bobot added a commit to bobot/jbuilder that referenced this issue May 25, 2021
@bobot
[Sites] Fix installation through opam
5559928 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue May 27, 2021
@bobot
[Sites] Fix installation through opam
05d05f2 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue May 28, 2021
@bobot
[Sites] Fix installation through opam
437a913 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
@ejgallego
Copy link
Collaborator

@bobot this is targetting 2.9 but the corresponding PR is not there.

@bobot
Copy link
Collaborator Author

bobot commented Jun 3, 2021

It does now have the 2.9 milestone

bobot added a commit that referenced this issue Jun 9, 2021
@bobot
[Sites] Fix installation through opam
bc4e430 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes #4198 #4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 14, 2021
@bobot
[Sites] Fix installation through opam
3cdf58c 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 14, 2021
@bobot
[Sites] Fix installation through opam
8ebfc24 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 15, 2021
@bobot
[Sites] Fix installation through opam
e93957e 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
@rgrinberg
Copy link
Member

@bobot should this be closed now?

@ejgallego
Copy link
Collaborator

@bobot should this be closed now?

This will be closed once #4730 is merged, as did only merge its 2.9 version, github won't close the bug as the PR was not merged in the "main" branch.

bobot added a commit to bobot/jbuilder that referenced this issue Jun 24, 2021
@bobot
[Sites] Fix installation through opam
88d8b0e 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes ocaml#4198 ocaml#4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit that referenced this issue Jun 24, 2021
@bobot
[Sites] Fix installation through opam
51e4940 
        - Substitute the files in an intermediate directory if needed
        - Backward compatible

        Fixes #4198 #4212

Signed-off-by: François Bobot <francois.bobot@cea.fr>
@bobot bobot closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobot bobot

Labels
None yet
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
3 participants
@bobot @rgrinberg @ejgallego