-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[install] dune install
seems to lack enough configuration options as to accommodate Linux's FSH
#4723
Closed
ejgallego opened this issue
Jun 10, 2021
· 1 comment
· Fixed by #4744 or ocaml/opam-repository#18904
Closed
[install] dune install
seems to lack enough configuration options as to accommodate Linux's FSH
#4723
ejgallego opened this issue
Jun 10, 2021
· 1 comment
· Fixed by #4744 or ocaml/opam-repository#18904
Labels
Comments
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 16, 2021
Fixes ocaml#4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 16, 2021
Fixes ocaml#4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 17, 2021
Fixes ocaml#4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 18, 2021
Fixes ocaml#4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 18, 2021
Fixes ocaml#4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 19, 2021
Fixes ocaml#4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
that referenced
this issue
Jun 19, 2021
Fixes #4723 This is an important fix for those using Dune to build, for example, Debian packages, as docdir is there `prefix/share/doc/package`, similarly for `etc`. Thus, I request for approval to ship this in 2.9. I have written the patch very conservatively, as to allow easy backporting, but once we release 2.9 it would be convenient to refactor this code so overridable directories are placed into a record. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this issue
Jun 21, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9-rc1) CHANGES: - Add `(enabled_if ...)` to `(mdx ...)` (ocaml/dune#4434, @emillon) - Add support for instrumentation dependencies (ocaml/dune#4210, fixes ocaml/dune#3983, @nojb) - Add the possibility to use `locks` with the cram tests stanza (ocaml/dune#4480, @voodoos) - Allow to set up merlin in a variant of the default context (ocaml/dune#4145, @TheLortex, @voodoos) - Add `(package ...)` to `(mdx ...)` (ocaml/dune#4691, fixes ocaml/dune#3756, @emillon) - Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml/dune#4713, @proux01) - Fix generation of merlin configuration when using `(include_subdirs unqualified)` on Windows (ocaml/dune#4745, @nojb) - Fix bug for the install of Coq native files when using `(include_subdirs qualified)` (ocaml/dune#4753, @ejgallego) - Allow users to specify install target directories for `doc` and `etc` sections. We add new options `--docdir` and `--etcdir` to both Dune's configure and `dune install` command. (ocaml/dune#4744, fixes ocaml/dune#4723, @ejgallego, thanks to @JasonGross for reporting this issue) - Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml/dune#4713, @proux01) - Fix issue where Dune would ignore `(env ... (coq (flags ...)))` declarations appearing in `dune` files (ocaml/dune#4749, fixes ocaml/dune#4566, @ejgallego @rgrinberg) - Disable some warnings on Coq 8.14 and `(lang coq (>= 0.3))` due to the rework of the Coq "native" compilation system (ocaml/dune#4760, @ejgallego)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this issue
Jun 29, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9.0) CHANGES: - Add `(enabled_if ...)` to `(mdx ...)` (ocaml/dune#4434, @emillon) - Add support for instrumentation dependencies (ocaml/dune#4210, fixes ocaml/dune#3983, @nojb) - Add the possibility to use `locks` with the cram tests stanza (ocaml/dune#4480, @voodoos) - Allow to set up merlin in a variant of the default context (ocaml/dune#4145, @TheLortex, @voodoos) - Add `(package ...)` to `(mdx ...)` (ocaml/dune#4691, fixes ocaml/dune#3756, @emillon) - Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml/dune#4713, @proux01) - Fix generation of merlin configuration when using `(include_subdirs unqualified)` on Windows (ocaml/dune#4745, @nojb) - Fix bug for the install of Coq native files when using `(include_subdirs qualified)` (ocaml/dune#4753, @ejgallego) - Allow users to specify install target directories for `doc` and `etc` sections. We add new options `--docdir` and `--etcdir` to both Dune's configure and `dune install` command. (ocaml/dune#4744, fixes ocaml/dune#4723, @ejgallego, thanks to @JasonGross for reporting this issue) - Fix issue where Dune would ignore `(env ... (coq (flags ...)))` declarations appearing in `dune` files (ocaml/dune#4749, fixes ocaml/dune#4566, @ejgallego @rgrinberg) - Disable some warnings on Coq 8.14 and `(lang coq (>= 0.3))` due to the rework of the Coq "native" compilation system (ocaml/dune#4760, @ejgallego) - Fix a bug where instrumentation flags would be added even if the instrumentatation was disabled (@nojb, ocaml/dune#4770) - Fix ocaml/dune#4682: option `-p` takes now precedence on environement variable `DUNE_PROFILE` (ocaml/dune#4730, ocaml/dune#4774, @bobot, reported by @dra27 ocaml/dune#4632) - Fix installation with opam of package with dune sites. The `.install` file is now produced by a local `dune install` during the build phase (ocaml/dune#4730, ocaml/dune#4645, @bobot, reported by @kit-ty-kate ocaml/dune#4198) - Fix multiple issues in the sites feature (ocaml/dune#4730, ocaml/dune#4645 @bobot, reported by @Lelio-Brun ocaml/dune#4219, by @Kakadu ocaml/dune#4325, by @toots ocaml/dune#4415)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this issue
Jul 1, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9.0) CHANGES: - Add `(enabled_if ...)` to `(mdx ...)` (ocaml/dune#4434, @emillon) - Add support for instrumentation dependencies (ocaml/dune#4210, fixes ocaml/dune#3983, @nojb) - Add the possibility to use `locks` with the cram tests stanza (ocaml/dune#4480, @voodoos) - Allow to set up merlin in a variant of the default context (ocaml/dune#4145, @TheLortex, @voodoos) - Add `(package ...)` to `(mdx ...)` (ocaml/dune#4691, fixes ocaml/dune#3756, @emillon) - Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml/dune#4713, @proux01) - Fix generation of merlin configuration when using `(include_subdirs unqualified)` on Windows (ocaml/dune#4745, @nojb) - Fix bug for the install of Coq native files when using `(include_subdirs qualified)` (ocaml/dune#4753, @ejgallego) - Allow users to specify install target directories for `doc` and `etc` sections. We add new options `--docdir` and `--etcdir` to both Dune's configure and `dune install` command. (ocaml/dune#4744, fixes ocaml/dune#4723, @ejgallego, thanks to @JasonGross for reporting this issue) - Fix issue where Dune would ignore `(env ... (coq (flags ...)))` declarations appearing in `dune` files (ocaml/dune#4749, fixes ocaml/dune#4566, @ejgallego @rgrinberg) - Disable some warnings on Coq 8.14 and `(lang coq (>= 0.3))` due to the rework of the Coq "native" compilation system (ocaml/dune#4760, @ejgallego) - Fix a bug where instrumentation flags would be added even if the instrumentatation was disabled (@nojb, ocaml/dune#4770) - Fix ocaml/dune#4682: option `-p` takes now precedence on environement variable `DUNE_PROFILE` (ocaml/dune#4730, ocaml/dune#4774, @bobot, reported by @dra27 ocaml/dune#4632) - Fix installation with opam of package with dune sites. The `.install` file is now produced by a local `dune install` during the build phase (ocaml/dune#4730, ocaml/dune#4645, @bobot, reported by @kit-ty-kate ocaml/dune#4198) - Fix multiple issues in the sites feature (ocaml/dune#4730, ocaml/dune#4645 @bobot, reported by @Lelio-Brun ocaml/dune#4219, by @Kakadu ocaml/dune#4325, by @toots ocaml/dune#4415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi folks,
we got some reports of dune-built packages installing incorrectly in Debian, and indeed, if we look at the code, we have:
dune/src/dune_engine/install.ml
Lines 146 to 167 in 6698257
which is incorrect for example for
(section doc)
, as it will install in/usr/doc
whereas Debian specifies/usr/share/doc
What should we do here? Should we just add a
--docdir
option in the same way opam-installer does support it?cc: @JasonGross
The text was updated successfully, but these errors were encountered: