Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dune 3.0 doesn't compile on macOS older than 10.13 #5430

Closed
anmonteiro opened this issue Feb 12, 2022 · 1 comment · Fixed by #5431
Closed

Dune 3.0 doesn't compile on macOS older than 10.13 #5430

anmonteiro opened this issue Feb 12, 2022 · 1 comment · Fixed by #5431
Assignees
@rgrinberg
Milestone
3.0.1

Comments

@anmonteiro
Copy link
Collaborator

Building Dune on macOS < 10.13 results in the following compilation errors:

       last 10 log lines:
       >       kFSEventStreamCreateFlagUseExtendedData |
       >       ^
       > src/fsevents/fsevents_stubs.c:315:5: error: use of undeclared identifier 'kFSEventStreamEventFlagItemCloned'
       >     kFSEventStreamEventFlagItemCloned};
       >     ^
       > src/fsevents/fsevents_stubs.c:320:22: error: invalid application of 'sizeof' to an incomplete type 'const FSEventStreamEventFlags []'
       >   size_t len = sizeof(all_flags) / sizeof(FSEventStreamEventFlags);
       >                      ^~~~~~~~~~~
       > 4 errors generated.

It seems like these APIs are only part of the 10.13 SDK.
@rgrinberg rgrinberg self-assigned this Feb 13, 2022
@rgrinberg rgrinberg added this to the 3.0.1 milestone Feb 13, 2022
@rgrinberg rgrinberg linked a pull request Feb 14, 2022 that will close this issue
fix(fsevents): restore compat with older mac #5431
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Feb 17, 2022
@rgrinberg
[new release] xdg, stdune, ordering, fiber, dyn, dune, dune-site, dun…
ece27a4 
…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.1)

CHANGES:

- Fix compilation on MacOS SDK < 10.13. The native watch mode is disabled in
  such instances (ocaml/dune#5431 fix ocaml/dune#5430, @rgrinberg)

- Do no add workspace_root to `BUILD_PATH_PREFIX_MAP` for projects before 3.0
  (5448, @rgrinberg)

- Fix performance regression in incremental builds (ocaml/dune#5439, @snowleopard)
@rgrinberg rgrinberg mentioned this issue Feb 17, 2022
Closed
@anmonteiro
Copy link
Collaborator Author

fixed by #5431

@barracuda156 barracuda156 mentioned this issue Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrinberg rgrinberg

Labels
None yet
Projects
None yet
Milestone
3.0.1
2 participants
@rgrinberg @anmonteiro