Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7445 check needs to be versioned #7471

Closed
emillon opened this issue Apr 3, 2023 · 0 comments · Fixed by #7476
Closed

#7445 check needs to be versioned #7471

emillon opened this issue Apr 3, 2023 · 0 comments · Fixed by #7476
Assignees
@Leonidas-from-XIV
Milestone
3.8.0

Comments

@emillon
Copy link
Collaborator

emillon commented Apr 3, 2023

As discussed in #7461, the check in #7445 needs to be versioned so that (package) is only accepted in head position if lang dune >= 3.8.
@emillon emillon added this to the 3.8.0 milestone Apr 3, 2023
@emillon emillon mentioned this issue Apr 3, 2023
Closed
Leonidas-from-XIV added a commit to Leonidas-from-XIV/dune that referenced this issue Apr 3, 2023
@Leonidas-from-XIV
Only enable package on dune lang 3.8+
fff94e6 
Closes ocaml#7471

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Apr 3, 2023
Merged
emillon pushed a commit to Leonidas-from-XIV/dune that referenced this issue Apr 11, 2023
@Leonidas-from-XIV @emillon
Only enable package on dune lang 3.8+
a12ebb5 
Closes ocaml#7471

Signed-off-by: Marek Kubica <marek@tarides.com>
emillon added a commit that referenced this issue Apr 11, 2023
@Leonidas-from-XIV @emillon
Only enable package in short-form rules on dune lang 3.8+ (#7476)
4fa0bfa 
* Only enable `package` on dune lang 3.8+

Closes #7471

Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Etienne Millon <me@emillon.org>
Co-authored-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leonidas-from-XIV Leonidas-from-XIV

Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Only enable package in short-form rules on dune lang 3.8+ Leonidas-from-XIV/dune
2 participants
@Leonidas-from-XIV @emillon