Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy between copy and copy_files #911

Closed
trefis opened this issue Jun 22, 2018 · 2 comments
Closed

Discrepancy between copy and copy_files #911

trefis opened this issue Jun 22, 2018 · 2 comments

Comments

@trefis
Copy link
Collaborator

trefis commented Jun 22, 2018

copy_files seems to only accept copying from subdirectories, while the copy action is perfectly happy to fetch things from an arbitrary directory.

Is there any fundamental reason to this restriction copy_files implements or could it be lifted?
@ghost
Copy link

ghost commented Jun 22, 2018

There was one initially but we should now be able to lift this restriction. Basically to determine what files copy_files <dir>/<glob> produces, dune must first determine what files can be generated in <dir>. When copy_files was implemented we couldn't express this fact, so we were simply interpreting the jbuild files in subdirectories first and restricted copy_files to copy files from subdirectories.

@trefis trefis mentioned this issue Jun 28, 2018
Merged
@nojb nojb mentioned this issue Sep 24, 2018
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Sep 24, 2018
@rgrinberg
[new release] dune (1.3.0)
f38ff31 
CHANGES:

- Support colors on Windows (ocaml/dune#1290, @diml)

- Allow `dune.configurator` and `base` to be used together (ocaml/dune#1291, fix
  ocaml/dune#1167, @diml)

- Support interrupting and restarting builds on file changes (ocaml/dune#1246,
  @kodek16)

- Fix findlib-dynload support with byte mode only (ocaml/dune#1295, @bobot)

- Make `dune rules -m` output a valid makefile (ocaml/dune#1293, @diml)

- Expand variables in `(targets ..)` field (ocaml/dune#1301, ocaml/dune#1320, fix ocaml/dune#1189, @nojb,
  @rgrinberg, @diml)

- Fix a race condition on Windows that was introduced in 1.2.0
  (ocaml/dune#1304, fix ocaml/dune#1303, @diml)

- Fix the generation of .merlin files to account for private modules
  (@rgrinberg, fix ocaml/dune#1314)

- Exclude the local opam switch directory (`_opam`) from the list of watched
  directories (ocaml/dune#1315, @dysinger)

- Fix compilation of the module generated for `findlib.dynload`
  (ocaml/dune#1317, fix ocaml/dune#1310, @diml)

- Lift restriction on `copy_files` and `copy_files#` stanzas that files to be
  copied should be in a subdirectory of the current directory.
  (ocaml/dune#1323, fix ocaml/dune#911, @nojb)
@trefis
Copy link
Collaborator Author

trefis commented Oct 5, 2018

This seems to have been fixed since v1.3.0

@trefis trefis closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trefis