Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove dune:stanza directive #10219

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Mar 5, 2024

Followup to #10152 and #10215. This removes uses of dune:stanza and the need for the custom dune domain.

@emillon emillon requested a review from christinerose as a code owner March 5, 2024 16:32
@emillon emillon added the docs Documentation improvements label Mar 5, 2024
@emillon emillon requested a review from ElectreAAS March 5, 2024 16:32
@emillon emillon force-pushed the doc-remove-dune-stanza branch from d70c5f5 to 7e5ddd2 Compare March 5, 2024 16:32
Copy link
Collaborator

@ElectreAAS ElectreAAS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to have less python :)

emillon added 2 commits March 6, 2024 14:15
Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon force-pushed the doc-remove-dune-stanza branch from 7e5ddd2 to 9e7f829 Compare March 6, 2024 13:15
@emillon
Copy link
Collaborator Author

emillon commented Mar 6, 2024

let's try not to be dogmatic about it. this was useful at some point, whatever was its implementation language. but we can always celebrate deleting code :)

@emillon emillon merged commit 633256c into ocaml:main Mar 6, 2024
25 of 27 checks passed
@emillon emillon deleted the doc-remove-dune-stanza branch March 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants