Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): read config file on windows #10500

Merged
merged 1 commit into from
May 14, 2024

Conversation

rgrinberg
Copy link
Member

Do not use OpamFile.Dot_config.read as it relies on some stubs to resolve paths in a special way we don't need.

Fix #9474

Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable workaround for Windows.

src/dune_rules/pkg_rules.ml Outdated Show resolved Hide resolved
Do not use OpamFile.Dot_config.read as it relies on some stubs to
resolve paths in a special way we don't need.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 9fe8f78e-d631-4455-99a1-d8549fef563f -->
@rgrinberg rgrinberg force-pushed the ps/rr/fix_pkg___read_config_file_on_windows branch from 9377f57 to f867362 Compare May 13, 2024 15:14
@rgrinberg
Copy link
Member Author

ping @Leonidas-from-XIV

@rgrinberg rgrinberg merged commit 29eecf2 into main May 14, 2024
27 of 28 checks passed
@rgrinberg rgrinberg deleted the ps/rr/fix_pkg___read_config_file_on_windows branch May 14, 2024 22:57
MA0010 pushed a commit to MA0010/dune that referenced this pull request Jun 5, 2024
Do not use OpamFile.Dot_config.read as it relies on some stubs to
resolve paths in a special way we don't need.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg: config reading not supported on Windows
2 participants