-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use 5.1.1 for tests #10763
chore: use 5.1.1 for tests #10763
Conversation
eff5fc7
to
44e7e36
Compare
44e7e36
to
43a12f3
Compare
@ElectreAAS this is now ready, the individual commits should make sense for review. |
4815b9c
to
6cb9608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bar my minuscule comment, everything looks good to me! Very happy to see this done :)
include: | ||
# OCaml trunk: | ||
- ocaml-compiler: ocaml-variants.5.3.0+trunk | ||
os: ubuntu-latest | ||
skip_test: true | ||
# OCaml 5: | ||
# OCaml 4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a typo? Or should we have a separate 4.14 CI run here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed the plan was to add a 4.14 build-only CI instead of the 4.13 one.
40c6a89
to
096a999
Compare
This bumps the version of OCaml used in tests to 5.1.1. The changes are: - version numbers are changed - CI is adjusted - some hashes are changed - the layout of the compiler is changed - some error messages are changed - Interesting changes to note: - on OCaml 5, with the dev profile, jsoo triggers a warning - the location of cmt files in install files is changed, because they are compressed and binary substitution does not happen At the time this PR is opened, 5.2 is available but requires more changes around warnings and alerts in alias modules so it will be updated in a second step. Also, there are a few components that we're leaving behind: - the monorepo benchmarks can be updated separately - the benchmark in bench.Dockerfile can be updated separately - coq cannot use OCaml 5 at the moment so it's forced to use 4.x - 5.1.1 doesn't support MSVC so we leave the build on 4.14 for now. Signed-off-by: Etienne Millon <me@emillon.org>
5c1b563
to
eae4106
Compare
This bumps the version of OCaml used in tests to 5.1.1. The changes are: - version numbers are changed - CI is adjusted - some hashes are changed - the layout of the compiler is changed - some error messages are changed - Interesting changes to note: - on OCaml 5, with the dev profile, jsoo triggers a warning - the location of cmt files in install files is changed, because they are compressed and binary substitution does not happen At the time this PR is opened, 5.2 is available but requires more changes around warnings and alerts in alias modules so it will be updated in a second step. Also, there are a few components that we're leaving behind: - the monorepo benchmarks can be updated separately - the benchmark in bench.Dockerfile can be updated separately - coq cannot use OCaml 5 at the moment so it's forced to use 4.x - 5.1.1 doesn't support MSVC so we leave the build on 4.14 for now. Signed-off-by: Etienne Millon <me@emillon.org>
This bumps the version of OCaml used in tests to 5.1.1.
The changes should be straightforward to review:
Interesting changes to note:
At the time this PR is opened, 5.2 is available but requires more changes around warnings and alerts in alias modules so it will be updated in a second step.
Also, there are a few components that we're leaving behind:
bench.Dockerfile
can be updated separately