refactor: Use Stdlib.String(Labels) implementations if available
#10825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
force-pushed
the
use-stdlib-code
branch
2 times, most recently
from
e6708dd to
ad2888c
Compare
Leonidas-from-XIV
force-pushed
the
use-stdlib-code
branch
from
ad2888c to
7d86fb1
Compare
rgrinberg
approved these changes
Aug 14, 2024
This uses a trick to define the fallback functions and overwrite them if they're available in the included module, otherwise they will be used. Needs to silence warning 32 but that's a small price to pay to avoid conditional compilation. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
use-stdlib-code
branch
from
7d86fb1 to
19115aa
Compare
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
…caml#10825) This uses a trick to define the fallback functions and overwrite them if they're available in the included module, otherwise they will be used. Needs to silence warning 32 but that's a small price to pay to avoid conditional compilation. Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the Stdlib implementations if the stdlib supports these. Has the advantage that if the stdlib has an optimized implementation, we automatically get to benefit of it.
This uses a trick to define the fallback functions and overwrite them if they're available in the included module, otherwise they will be used. Needs to silence warning 32 but that's a small price to pay to avoid conditional compilation.