refactor(engine): remove [Dune_sexp] from the engine #10826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dune_sexp belongs to dune's frontend and the engine has no business relying on it. This is a change we've done internally, so this is just syncing. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 4fea0fec-94a1-4d17-a59e-ca8b66e8d9f9 -->
rgrinberg
deleted the
ps/rr/refactor_engine___remove__dune_sexp__from_the_engine
branch
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
Dune_sexp belongs to dune's frontend and the engine has no business relying on it. This is a change we've done internally, so this is just syncing. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune_sexp belongs to dune's frontend and the engine has no business relying on it.
This is a change we've done internally, so this is just syncing.
Signed-off-by: Rudi Grinberg me@rgrinberg.com