pkg: add support for opam depexts
#10900
Conversation
| > EOF | ||
|
|
||
| Lock, build, and run the executable in the project: | ||
| $ dune pkg lock |
There was a problem hiding this comment.
Instead of relying on the solver, you can just write foo.pkg directly.
|
I tweaked the error message a bit. The rest looks good but testing the |
| @@ -0,0 +1,61 @@ | |||
| When a package fails to build, dune will print opam depexts warning. | |||
There was a problem hiding this comment.
Can you move these two tests into a depexts sub-directory?
`dune` will just print a warning message whenever a package fails to build. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
moyodiallo
force-pushed
the
pkg-depexts
branch
from
345e4a4 to
a65dc92
Compare
|
Suggestions applied thanks. |
|
we tried this with |
|
this is likely because we use |
|
I'm for reverting it until we fix the subsequent bug. |
|
Do you want to add a repro test to demonstrate the issue before you revert? |
|
A question: is |
|
|
|
This variable is specific to |
* pkg: add support for opam depexts `dune` will just print a warning message whenever a package fails to build. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
dunewill just print a warning message whenever a package fails to build. The warning message would be a list of thedepextsdependency without checking if they exist in the current OS or not.This is one of the way for supporting depexts that mentioned in #9294.