Add odoc dev tool #10914
Open
Add odoc dev tool #10914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't odoc have the same limitation as lsp? I.e it needs to be compiled with the same version of OCaml as the project. |
rgrinberg
requested changes
Sep 16, 2024
moyodiallo
suggested changes
Sep 18, 2024
Remove references to ocamlformat from the fetch rules and create fetch rules for all dev tools. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
dev-tool-odoc
branch
2 times, most recently
from
1b86797
to
ea33c5b
Compare
You're totally right. I didn't realize this but that explains some of the weird errors I've run into with odoc recently: E.g. I'll borrow some of the code from my ocamllsp dev-tool pr to make sure that the same compiler is used to build odoc as is used to build the project. |
gridbugs
force-pushed
the
dev-tool-odoc
branch
from
ea33c5b
to
c43d102
Compare
The command `dune ocaml doc` will now lock, build, and run odoc as a dev tool if the dev tools feature is enabled. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
dev-tool-odoc
branch
from
c43d102
to
ab52547
Compare
|
I updated this so that it always uses the same version of the compiler to build odoc as it does to build the project and added some tests that it relocks the odoc dev tool to keep the compiler dependency in sync with the project. |
rgrinberg
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
dune ocaml docwill now lock, build, and run odoc as a dev tool if the dev tools feature is enabled.