pkg: relax version constraints for ocamlformat dev tool #11019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
force-pushed
the
relax-ocamlformat-version-constraint
branch
2 times, most recently
from
a1c7252 to
1ecdbcd
Compare
bin/lock_dev_tool.ml
Outdated
|
|
||
| Read more at: https://opam.ocaml.org/doc/Manual.html#Version-ordering | ||
| *) | ||
| let max_version = String.concat ~sep:"" [ min_version; "___" ] in |
There was a problem hiding this comment.
Suggested change
| let max_version = String.concat ~sep:"" [ min_version; "___" ] in | |
| let max_version = min_version ^ "___" in |
|
Would you like to add a test ? |
gridbugs
force-pushed
the
relax-ocamlformat-version-constraint
branch
2 times, most recently
from
98940f5 to
4ccfdbb
Compare
|
Added a test |
Leonidas-from-XIV
approved these changes
Oct 21, 2024
Previously dune would install the exact version of ocamlformat specified in the .ocamlformat file in the project's root. This prevents alternative distributions of the ocamlformat package from being used, as these typically append a suffix to the version number. The motivation for this change is supporting a binary dev tools distribution where the ocamlformat package is named like "ocamlformat.0.26.2+binary", and we want that package to be installable when the .ocamlformat file of a project specifies "version=0.26.2". Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
relax-ocamlformat-version-constraint
branch
from
4ccfdbb to
0544313
Compare
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
Previously dune would install the exact version of ocamlformat specified in the .ocamlformat file in the project's root. This prevents alternative distributions of the ocamlformat package from being used, as these typically append a suffix to the version number. The motivation for this change is supporting a binary dev tools distribution where the ocamlformat package is named like "ocamlformat.0.26.2+binary", and we want that package to be installable when the .ocamlformat file of a project specifies "version=0.26.2". Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously dune would install the exact version of ocamlformat specified in the .ocamlformat file in the project's root. This prevents alternative distributions of the ocamlformat package from being used, as these typically append a suffix to the version number.
The motivation for this change is supporting a binary dev tools distribution where the ocamlformat package is named like "ocamlformat.0.26.2+binary", and we want that package to be installable when the .ocamlformat file of a project specifies "version=0.26.2".