flake: add overlay #11192
Open
flake: add overlay #11192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that consumers can more simply use the packages exported by this flake, by adding the overlay when they instantiate nixpkgs. Signed-off-by: Lorenzo Manacorda <lorenzo@mailbox.org>
Signed-off-by: Lorenzo Manacorda <lorenzo@mailbox.org>
anmonteiro
reviewed
Dec 12, 2024
|
@anmonteiro would you prefer it were called |
|
I'm not sure. I'm happy to try it out like this until anyone complains. |
anmonteiro
approved these changes
Dec 14, 2024
anmonteiro
reviewed
Dec 14, 2024
| @@ -46,18 +46,11 @@ | |||
| configureFlags = [ "-native-compiler" "yes" ]; | |||
| }); | |||
| }) | |||
| self.overlays.default | |||
There was a problem hiding this comment.
not the biggest fan of applying the own overlay when declaring pkgs. can we do it another way? maybe a common function that both the overlays and outputs call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that consumers can more simply use the packages exported by this flake, by adding the overlay when they instantiate nixpkgs.
I think a cleaner way (which would avoid the ugly
//at the end) would be to get rid of flake-utils entirely, taking inspiration from rust-overlay.But that is a bigger change.