Update trunk for next OCaml release #11293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <marek@tarides.com>
rgrinberg
approved these changes
Jan 14, 2025
ElectreAAS
pushed a commit
to ElectreAAS/dune
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Marek Kubica <marek@tarides.com>
chris-armstrong
pushed a commit
to chris-armstrong/dune
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Marek Kubica <marek@tarides.com> Signed-off-by: Chris Armstrong <chris-armstrong@users.noreply.github.com>
Sudha247
pushed a commit
to Sudha247/dune
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI keeps breaking because
ocaml-variants.5.3.0+trunkis gone, now that 5.3.0 was released. This PR updates it to 5.4.0.I don't think this is good in general, since this will keep breaking every time a release is cut and the old
+trunkremoved from opam-repository and will require someone to come in and fix CI while all PRs fail CI due to unrelated failures. I think we should drop this particular solution and if we want to keep testing againsttrunk, use the trunk from git instead of going through opam releases.