feat(rpc): add --wait to dune rpc ping #12138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@ElectreAAS with this you can use |
shonfeder
approved these changes
Aug 8, 2025
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
This looks good and will be very helpful. Thanks!
I have one suggestion about documentation and one question, but LGTM.
rgrinberg
requested changes
Aug 10, 2025
Alizter
force-pushed
the
dune-rpc-ping-wait
branch
3 times, most recently
from
0d44a7f to
c5dbc48
Compare
rgrinberg
approved these changes
Aug 10, 2025
shonfeder
approved these changes
Aug 11, 2025
Alizter
commented
Aug 11, 2025
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
dune-rpc-ping-wait
branch
from
c5dbc48 to
3e514d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12134