Add missing link flags to c_test #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris00
approved these changes
Sep 15, 2018
emillon
approved these changes
Sep 17, 2018
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg
force-pushed
the
link-flags-c_test
branch
from
f537995 to
8778b85
Compare
|
It's quite necessary even. As it's blocking the fix of ocaml-ssl :/ |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 17, 2018
CHANGES: - Enrich the `dune` Emacs mode with syntax highlighting and indentation. New file `dune-flymake` to provide a hook `dune-flymake-dune-mode-hook` to enable linting of dune files. (ocaml/dune#1265, @Chris00) - Pass `link_flags` to `cc` when compiling with `Configurator.V1.c_test` (ocaml/dune#1274, @rgrinberg) - Fix digest calculation of aliases. It should take into account extra bindings passed to the alias (ocaml/dune#1277, fix ocaml/dune#1276, @rgrinberg) - Fix a bug causing `dune` to fail eagerly when an optional library isn't available (ocaml/dune#1281, @diml)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 17, 2018
CHANGES: - Enrich the `dune` Emacs mode with syntax highlighting and indentation. New file `dune-flymake` to provide a hook `dune-flymake-dune-mode-hook` to enable linting of dune files. (ocaml/dune#1265, @Chris00) - Pass `link_flags` to `cc` when compiling with `Configurator.V1.c_test` (ocaml/dune#1274, @rgrinberg) - Fix digest calculation of aliases. It should take into account extra bindings passed to the alias (ocaml/dune#1277, fix ocaml/dune#1276, @rgrinberg) - Fix a bug causing `dune` to fail eagerly when an optional library isn't available (ocaml/dune#1281, @diml) - ocamlmklib should use response files only if ocaml >= 4.08 (@1268, @bryphe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fear that this will require 1.2.1. This regression has been present for a while, but now I need this function in ocaml-ssl.