WIP don't control concurrency from INSIDE_DUNE #12800
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Unfortuantely due to the way build forwarding warnings work we warn alot since DUNE_JOBS differs from the default. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Leonidas-from-XIV
force-pushed
the
push-ysnonzkmwzym
branch
from
0cb608f to
8822feb
Compare
|
FTR oxcaml still won't build with the correct concurrency with this patch because they are specifically vendoring Dune 3.20 and using that to build. We therefore have to patch their opam build to not do that. If we are going to do that anyway, then we might as well unset |
|
Another issue with this PR is that comparing against |
|
I do wonder why the CI doesn't want to run the jobs that run the test-suite… |
|
@Leonidas-from-XIV The nix tests are a dependency of the rest of the tests. That way we can catch errors early and not bother using up all the allocated machines. The fact that the environment is Nix doesn't mean much here, its just the regular test suite. |
|
Yes, I can confirm that this doesn't help the OxCaml build by itself. I believe we will need to update the Dune version used to bootstrap the compiler to actually see the difference. |
3 participants
No description provided.