Skip to content

Tiny error printing bugfix: pin error showing the same loc twice. #13224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alizter merged 1 commit into from
Jan 7, 2026
+2 −2
Merged

Tiny error printing bugfix: pin error showing the same loc twice. #13224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dune_pkg/pin.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ module DB = struct
[ Pp.textf
"package %S is defined in more than one source"
(Package_name.to_string name)
; Pp.textf "it is also defined in %s" (Loc.to_file_colon_line (fst lhs).loc)
; Pp.textf "it is also defined in %s" (Loc.to_file_colon_line (fst rhs).loc)
])
; context
}
Expand Down
2 changes: 1 addition & 1 deletion test/blackbox-tests/test-cases/pkg/pin-stanza/override-single-workspace.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ select a priority:
4 | (package (name bar)))
^^^^^^^^^^^^^^^^^^^^
Error: package "bar" is defined in more than one source
it is also defined in prj1/dune-project:4
it is also defined in prj2/dune-project:4
[1]
Loading