per-context cram test builds multiple contexts #13231
Merged
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sudha247
commented
Jan 7, 2026
Sudha247
force-pushed
the
per-context-test-fix
branch
from
6585859 to
718e57f
Compare
rgrinberg
approved these changes
Jan 9, 2026
Alizter
reviewed
Jan 9, 2026
| version: 0.0.1 | ||
|
|
||
| $ dune build @@_build/foo/pkg-install | ||
| building from foo |
Collaborator
There was a problem hiding this comment.
What is strange is that I don't observe this behaviour myself in #13237. @rgrinberg any idea what the difference is? There, in each context, context_name is reported as default.
Collaborator
There was a problem hiding this comment.
What if instead of dune exec you dune build _build/<context>/target and then execute the binaries? Maybe the issue is that dune exec is not passing the context to the build properly?
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Sudha247
force-pushed
the
per-context-test-fix
branch
from
718e57f to
66f51f9
Compare
Leonidas-from-XIV
approved these changes
Jan 9, 2026
Collaborator
Author
|
The benchmark failure seems unrelated; merging. Thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the test build from multiple contexts as discussed in #13217. This is a minimal change compared to #13127.