chore: shellcheck our shell scripts #13233
Merged
+132
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Leonidas-from-XIV
approved these changes
Jan 8, 2026
Leonidas-from-XIV
added a commit
that referenced
this pull request
Jan 9, 2026
This PR follows up #13233 and solves remaining issues shellcheck was complaining about. I've opted to disable [SC2016](https://www.shellcheck.net/wiki/SC2016) as it states: > This suggestion is primarily meant to help newbies who assume single and double quotes are basically the same, like in Python and JavaScript. It's not at all meant to discourage experienced users from using single quotes in general. If you are well aware of the difference, please do not hesitate to permanently disable this suggestion Writing the code `"\$SANDBOX"` to satisfy SC is less readable and IMHO worse, thus I would actually suggest we globally disable it. --------- Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.