Fix hash collision once and for all #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
reviewed
Dec 3, 2018
Fix #1524 Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
rgrinberg
approved these changes
Dec 3, 2018
ghost
merged commit
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Dec 4, 2018
CHANGES: - Fix hash collision for on-demand ppx rewriters once and for all (ocaml/dune#1602, fixes ocaml/dune#1524, @diml)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be easier to check the correctness of the new code. We no longer need to clear the reverse table between builds given that the values stored in it are pure.
Fixes #1524