Fix variants #1999
Merged
Fix variants #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the definition of uniqueness introduced by If you want to use this hack properly, I suggest you simply use I will have another look to see what a valid fix would look like. |
|
Oops you're right it's confusing, I actually meant to define uniqueness on name + path. |
|
|
Signed-off-by: Lucas Pluvinage <lucas.pluvinage@gmail.com>
…s define the same library. Signed-off-by: Lucas Pluvinage <lucas.pluvinage@gmail.com> Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the variants implementation.
If you have several scopes with the same implementation library inside, the same implementation is considered multiple times for variant selection, which creates a conflict.
Such case happens when there are multiple
.opamin a project directory.This is the minimal fix which uses a
Setto eliminate duplicates. The proper fix would be to changeVariant.Map.Multi.tto be a map from variant to lib_info sets. Is this enough or should I make the proper fix ?