Remove caching of scopes #2047
Merged
Remove caching of scopes #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not seem to buy us anything performance wise Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
aalekseyev
approved these changes
Apr 11, 2019
|
Yeah, I wasn't counting on any :). I doubt this would ever be a bottleneck in any real world build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the case of the caching that was present in
File_tree.t. I've benchmarked this change on the ocaml platform, and if it has an impact, it's infact negative as this PR seems to offer a small but measurable speed up. And in fact, the map lookup introduced here could be even faster if we had some sort of a trie based map of paths.I'm aware that there's some duplication introduced between this PR and #2043. I will address it once both PR's are merged.