Rework install doc #2294
Merged
Rework install doc #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
mentioned this pull request
emillon
reviewed
Jun 18, 2019
It regroups the various bits about installing things and clarify the section semantics for file installation. Closes #2198 Signed-off-by: Anil Madhavapeddy <anil@recoil.org> Signed-off-by: Jeremie Dimino <jeremie@dimino.org> Co-Authored-By: Etienne Millon <etienne.millon@gmail.com>
|
@emillon, does it look ready for approval? |
mlasson
pushed a commit
to mlasson/dune
that referenced
this pull request
Jul 19, 2019
It regroups the various bits about installing things and clarify the section semantics for file installation. Closes ocaml#2198 Signed-off-by: Anil Madhavapeddy <anil@recoil.org> Signed-off-by: Jeremie Dimino <jeremie@dimino.org> Co-Authored-By: Etienne Millon <etienne.millon@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section "Installation" to the manual that regroups all the information about installing things with Dune. That should make things clearer and more discoverable.