Remove the option in Dune_env.Stanza.t option #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobot
force-pushed
the
simplify-dune_env-option
branch
from
46da067 to
1d8f71e
Compare
rgrinberg
approved these changes
Jul 30, 2019
src/dune_env.mli
Outdated
| val find : t -> profile:string -> config option | ||
| val env_vars : t -> profile:string -> Env.t |
There was a problem hiding this comment.
To me it's quite confusing that this function doesn't have an option type like find. I think that the caller should turn the None to empty, or we should change find to work symmetrically.
There was a problem hiding this comment.
You are right it simplifies other things and I removed env_vars.
bobot
force-pushed
the
simplify-dune_env-option
branch
from
0c4c173 to
742be4e
Compare
since it is already a list Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot
force-pushed
the
simplify-dune_env-option
branch
from
742be4e to
33967cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is already a list, it simplifies some part and remove one negligible optimization, which allowed to not create
env_nodeof emptyenv.The documentation for
env-varsis updated.